Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the array PROMPT_COMMAND (bash >= 5.1) #141

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Support the array PROMPT_COMMAND (bash >= 5.1) #141

merged 1 commit into from
Mar 13, 2023
+39 −17

Conversation

akinomyoga
Copy link
Contributor

@akinomyoga akinomyoga commented Mar 6, 2023 •
edited
Loading

This is a fix for the issue I reported in #130 (comment).

ShellCheck seems to have started to complain about -lt, -eq, etc. in the conditional command [[ ... ]], so I also included a commit (77aec5f) to workaround the shellcheck warning.

@akinomyoga
Copy link
Contributor Author

I decided to separate a PR for a possible solution to #140 because it would conflict with #128.

@akinomyoga akinomyoga marked this pull request as draft March 6, 2023 23:51
@akinomyoga akinomyoga marked this pull request as ready for review March 6, 2023 23:54
@akinomyoga akinomyoga force-pushed the array-PROMPT_COMMAND branch from 203ad78 to a16daaf Compare March 7, 2023 00:14
dimo414
dimo414 reviewed Mar 7, 2023
View reviewed changes
bash-preexec.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga force-pushed the array-PROMPT_COMMAND branch 2 times, most recently from 219ae02 to b7fb4ae Compare March 7, 2023 00:23
@akinomyoga akinomyoga mentioned this pull request Mar 7, 2023
Merged
@akinomyoga akinomyoga force-pushed the array-PROMPT_COMMAND branch from b7fb4ae to 788214a Compare March 7, 2023 02:21
@akinomyoga
Copy link
Contributor Author

I have rebased the PR on top of the latest master (with #128 included).

@akinomyoga akinomyoga force-pushed the array-PROMPT_COMMAND branch from 788214a to 7fb59da Compare March 7, 2023 02:22
@akinomyoga akinomyoga force-pushed the array-PROMPT_COMMAND branch from 7fb59da to 0d2b598 Compare March 7, 2023 03:00
@rcaloras rcaloras merged commit 7ad48e1 into rcaloras:master Mar 13, 2023
@rcaloras
Copy link
Owner

👍 thanks for the PR @akinomyoga! Merging.

@akinomyoga akinomyoga deleted the array-PROMPT_COMMAND branch March 13, 2023 00:28
@akinomyoga
Copy link
Contributor Author

Thanks!

@zachbai zachbai mentioned this pull request Jun 22, 2023
Open
@akinomyoga akinomyoga mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimo414 dimo414 dimo414 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akinomyoga @rcaloras @dimo414